Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectator - Do not use DISPLAY macro #224

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Spectator - Do not use DISPLAY macro #224

merged 2 commits into from
Sep 2, 2024

Conversation

veteran29
Copy link
Member

When merged this pull request will:

  • title

For some reason the DISPLAY macro is replaced with nothing by arma. Does not seem to be an issue in release as HEMTT does the preprocessing for sqfc. IDK why it seems to be fine for other macros in the file.

23:20:06 Error in expression <lElements = ["TreeGetAllElements"] call ;
private _groupElements = _allElements >
23:20:06   Error position: <;
private _groupElements = _allElements >
23:20:06   Error Invalid number in expression
23:20:06 File z\afm\addons\spectator\functions\RscDisplayEGSpectator.sqf..., line 92

image

@veteran29 veteran29 added the bugfix Fix for a bug label Aug 21, 2024
@veteran29 veteran29 requested a review from a team as a code owner August 21, 2024 21:27
@veteran29 veteran29 requested review from 3Mydlo3 and removed request for a team August 21, 2024 21:27
@veteran29 veteran29 added this to the 1.17.1 milestone Aug 21, 2024
@veteran29 veteran29 merged commit 8356169 into master Sep 2, 2024
5 checks passed
@veteran29 veteran29 deleted the spectator-fix-script-errors branch September 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3Mydlo3 3Mydlo3 3Mydlo3 approved these changes

Assignees
No one assigned
Labels
bugfix Fix for a bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @3Mydlo3